Skip to content

fix(demos): solution demo link color + trading demo cleanup - #1864

Merged
youssefea merged 1 commit into
masterfrom
fix-solutions-demos-trading
Aug 28, 2026
Merged

fix(demos): solution demo link color + trading demo cleanup#1864
youssefea merged 1 commit into
masterfrom
fix-solutions-demos-trading

Conversation

@youssefea

Copy link
Copy Markdown
Contributor

What changed? Why?

Fixes several issues in the solutions demos:

  • "See technical details" link color — the anchor text on the final "See technical details →" link was rendering with a hard-to-read color because the platform's anchor styling overrode the .wf-btn class color. Added an a.wf-btn, a.wf-btn:visited { color } rule in all four solution demo snippets (DeFiDemo, AssetDemo, PaymentsDemo, StablecoinDemo) so the link text is always white (on-blue).
  • Trading demo flow — simplified from Quote → Approve USDC → Simulate swap → Submit swap to Quote → Simulate swap → Approve + submit swap. Removed the standalone "Approve USDC" step and folded the approval into the final submit step ("Approve + submit swap").
  • Integrate Trading page — removed the "Build a Safe Trade Review" and "Production Checklist" sections, dropped the "Supported Chains" card from the 0x Documentation card group, and changed "straightforward ERC-20" → "B20 or ERC-20".

Notes to reviewers

  • The DeFiDemo.jsx snippet is an illustrative mock demo, not one of the byte-for-byte verified samples (examples/verified-doc-samples/typescript/src/defi/trade-0x.ts). The verified sample and its MDX code block are unchanged.
  • The a.wf-btn color rule uses the existing --wf-on-blue token, which is #ffffff in both light and dark themes, so the link text stays white in all themes.

How has it been tested?

  • node scripts/lint-mdx.js — 0 errors, 0 warnings.
  • node scripts/verify-doc-samples.js — all 72 verified samples still pass.
  • mintlify dev local render to visually confirm the link color and the updated trading step flow.

Co-Authored-By: Claude noreply@anthropic.com

@mintlify

mintlify Bot commented Aug 28, 2026

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
base 🟢 Ready View Preview Aug 28, 2026, 10:54 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@cb-heimdall

cb-heimdall commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

- Force the "See technical details" anchor text to always use the
  on-blue color (white) across all solution demo snippets, since the
  platform anchor styling was overriding the .wf-btn color and rendering
  the link text with a hard-to-read color.
- Simplify the trading demo flow from Quote → Approve USDC → Simulate
  swap → Submit swap to Quote → Simulate swap → Approve + submit swap,
  removing the standalone approve step and folding approval into the
  final submit step.
- On the Integrate Trading page, remove the "Build a Safe Trade Review"
  and "Production Checklist" sections, drop the "Supported Chains" card,
  and change "straightforward ERC-20" to "B20 or ERC-20".

Co-Authored-By: Claude <noreply@anthropic.com>
@youssefea
youssefea merged commit 7f84082 into master Aug 28, 2026
9 checks passed
@youssefea
youssefea deleted the fix-solutions-demos-trading branch August 28, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants